Sync rustc_codegen_cranelift #114666
Merged
Sync rustc_codegen_cranelift #114666
+194
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a left over from when build_system/main.rs was at ./y.rs.
Pass `preserve_frame_pointers` to Cranelift
…mpiler-errors Fix ICE failed to get layout for ReferencesError Fixes rust-lang#114435 r? `@compiler-errors`
Co-authored-by: Ralf Jung <[email protected]>
…r=cjgillot Add a new `compare_bytes` intrinsic instead of calling `memcmp` directly As discussed in rust-lang#113435, this lets the backends be the place that can have the "don't call the function if n == 0" logic, if it's needed for the target. (I didn't actually *add* those checks, though, since as I understood it we didn't actually need them on known targets?) Doing this also let me make it `const` (unstable), which I don't think `extern "C" fn memcmp` can be. cc `@RalfJung` `@Amanieu`
rustbot
added
S-waiting-on-review
|
@bors r+ p=1 subtree sync |
bors
added
S-waiting-on-bors
Closed
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (08d00b4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.289s -> 632.868s (0.09%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small bug fixes this time. In addition I fixed the test suite after the introduction of
#![deny(internal_feature)]broke it.r? @ghost
@rustbot label +A-codegen +A-cranelift +T-compiler